Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <261660418.1234798383403.JavaMail.jira@brutus>
Date: Mon, 16 Feb 2009 07:33:03 -0800 (PST)
From: "Phil Steitz (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (DBCP-280) SequencedHashMap constructor calls
 overridable method; throws Error
In-Reply-To: <1954707823.1232927579635.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DBCP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673904#action_12673904 ] 

Phil Steitz commented on DBCP-280:
----------------------------------

I would like to leave the collections classes included in dbcp in exactly the same state that they were when incorporated unless and until a dbcp-impacting bug with one of these classes is identified.  Both SequencedHashMap and LRUMap (the class actually used) have package scope and javadoc headers indicating their lineage and that they are not to be made public.  I do not want us to take on maintaining forked versions unless and until we need to.

> SequencedHashMap constructor calls overridable method; throws Error
> -------------------------------------------------------------------
>
>                 Key: DBCP-280
>                 URL: https://issues.apache.org/jira/browse/DBCP-280
>             Project: Commons Dbcp
>          Issue Type: Bug
>            Reporter: Sebb
>
> The constructor SequencedHashMap(Map) calls the public non-final method putAll().
> This is likely to cause problems if the class is ever extended. Possible solution: extract the code into a common private method.
> The next() method also throws an Error if the return type is unexpected.
> It should probably return IllegalStateException or similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.