Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 53368 invoked from network); 25 Feb 2009 07:03:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Feb 2009 07:03:38 -0000 Received: (qmail 29208 invoked by uid 500); 25 Feb 2009 07:03:33 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 29145 invoked by uid 500); 25 Feb 2009 07:03:33 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 29115 invoked by uid 99); 25 Feb 2009 07:03:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2009 23:03:33 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Feb 2009 07:03:23 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0AF09234C495 for ; Tue, 24 Feb 2009 23:03:02 -0800 (PST) Message-ID: <1411008429.1235545382043.JavaMail.jira@brutus> Date: Tue, 24 Feb 2009 23:03:02 -0800 (PST) From: "John Trimble (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (JXPATH-127) Change dynamic class loading to consult context class loader. In-Reply-To: <454945541.1230073844262.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JXPATH-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Trimble updated JXPATH-127: -------------------------------- Attachment: jxpath-14-classloading-widest-scope.patch A modification of the classloading_fix_jxpath14.patch patch. Does not use a dummy SecurityManager to get the call stack. > Change dynamic class loading to consult context class loader. > ------------------------------------------------------------- > > Key: JXPATH-127 > URL: https://issues.apache.org/jira/browse/JXPATH-127 > Project: Commons JXPath > Issue Type: Improvement > Reporter: John Trimble > Fix For: post-1.3 > > Attachments: classloading_fix_jxpath14.patch, jxpath-14-classloading-widest-scope.patch > > > For dynamically loading classes, JXPath currently uses Class.forName(...). This means all classes loaded by JXPath must be visible to whatever class loader loaded JXPath. This is restrictive in large frameworks and web applications where multiple class loaders are in use. In particular, in an EJB3 application deployed on Weblogic, the shared jars between different EJB modules are loaded with a separate class loader than the modules themselves. Consequently, if the jxpath.jar is among the general libraries for the application, then a specific EJB module will be unable to reference static methods of classes within its own module in an xpath expression. For example, consider the following lines of code in an EJB module class: > JXPathContext context = JXPathContext.newContext(new Object()); > Object value = context.getValue("SomeClass.getSomething()"); > This will fail, with a ClassNotFoundException, if SomeClass is a class in the module, but jxpath is a general library for the application. > Attached (or will be once I figure out how) is a patch for JXPath that gets around this issue. The patch changes the class loading strategy to use the context class loader, when it appears appropriate, to dynamically load classes. The strategy is based on suggestions and example code from: > http://www.javaworld.com/javaworld/javaqa/2003-06/01-qa-0606-load.html > Assuming all class loaders involved delegate to their parent class loader (as recommended in the API), currently working code, that uses JXPath, should only be affected by this change if the current class loader (the class loader that loaded JXPath) is not in an ancestor/descendant relationship with the context class loader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.