commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DBCP-280) SequencedHashMap constructor calls overridable method; throws Error
Date Mon, 16 Feb 2009 15:33:03 GMT

    [ https://issues.apache.org/jira/browse/DBCP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673904#action_12673904
] 

Phil Steitz commented on DBCP-280:
----------------------------------

I would like to leave the collections classes included in dbcp in exactly the same state that
they were when incorporated unless and until a dbcp-impacting bug with one of these classes
is identified.  Both SequencedHashMap and LRUMap (the class actually used) have package scope
and javadoc headers indicating their lineage and that they are not to be made public.  I do
not want us to take on maintaining forked versions unless and until we need to.

> SequencedHashMap constructor calls overridable method; throws Error
> -------------------------------------------------------------------
>
>                 Key: DBCP-280
>                 URL: https://issues.apache.org/jira/browse/DBCP-280
>             Project: Commons Dbcp
>          Issue Type: Bug
>            Reporter: Sebb
>
> The constructor SequencedHashMap(Map) calls the public non-final method putAll().
> This is likely to cause problems if the class is ever extended. Possible solution: extract
the code into a common private method.
> The next() method also throws an Error if the return type is unexpected.
> It should probably return IllegalStateException or similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message