commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <>
Subject [jira] Commented: (COLLECTIONS-317) AbstractHashedMap(Map map) constructor calls overridable non-final method
Date Mon, 16 Feb 2009 16:49:00 GMT


Matt Benson commented on COLLECTIONS-317:

Another, albeit somewhat--different, option would be to expose the implementation detail of
putAll() being called in the javadoc specification of the method.  Then a subclass implementor
could simply choose to call a different super constructor if appropriate.

> AbstractHashedMap(Map map) constructor calls overridable non-final method
> -------------------------------------------------------------------------
>                 Key: COLLECTIONS-317
>                 URL:
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>            Reporter: Sebb
>            Priority: Minor
> The constructor AbstractHashedMap(Map map) calls the public non-final method putAll()
from the same class.
> This is likely to cause problems if the method is ever overridden, as the parent may
not have been completely initialised when the sub-class method is invoked. 
> Possible solution: extract the code into a common private method. Or make the method

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message