commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wyatt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DBCP-282) defaultReadOnly not honored in server.xml for PerUserPoolDataSource
Date Tue, 03 Feb 2009 15:03:59 GMT

    [ https://issues.apache.org/jira/browse/DBCP-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669979#action_12669979
] 

Josh Wyatt commented on DBCP-282:
---------------------------------

I was able to get the desired behavior using commons-dbcp-1.2.2 with the following patch against
PerUserPoolDataSource.java.
This was a backport of a similar code change noted in 1.3, and congruent with the research/recommendation
in DBCP-178.

--- commons-dbcp-1.2.2-src/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java
     2007-03-25 17:51:25.000000000 -0400
+++ commons-dbcp-1.2.2b-src/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java
    2009-01-31 09:36:31.000000000 -0500
@@ -419,7 +419,9 @@
         if (defaultTransactionIsolation != UNKNOWN_TRANSACTIONISOLATION) {
             con.setTransactionIsolation(defaultTransactionIsolation);
         }
-        con.setReadOnly(defaultReadOnly);
+        if (con.isReadOnly() != defaultReadOnly) {
+           con.setReadOnly(defaultReadOnly);
+       }
     }
 
     /**

Our testing indicates that this completely disables the defaultReadOnly parameter for PerUserPoolDataSource,
which may not be desirable for some users.

> defaultReadOnly not honored in server.xml for PerUserPoolDataSource
> -------------------------------------------------------------------
>
>                 Key: DBCP-282
>                 URL: https://issues.apache.org/jira/browse/DBCP-282
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>         Environment: Tomcat 4.1.29/Apache-2.0.55/Oracle JDBC on RedHat ES3.0 on i386
>            Reporter: Josh Wyatt
>             Fix For: 1.3
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Running dbcp-1.2.2 on Apache-2.0.55/Tomcat-4.1.29/Jakarta on Linux, using JDBC to connect
to Oracle 10g DB.
> We are seeing the constant SET TRANSACTION READ WRITE activity against the DB connection,
and although I appreciate the discussion about a new configuration option, I am not able to
figure out how to disable this activity.
> Background on this issue can be found at:
> http://issues.apache.org/jira/browse/DBCP-178
> For reference, assume that we do not have control over the codebase, although we have
full control over the server configuration (server.xml, etc).
> I found the configuration options page for DBCP- but there appears to be no discussion
on the logistics/mechanics of how to set or change these configuration options.
> Our connections are implemented as  type="org.apache.commons.dbcp.datasources.PerUserPoolDataSource"
in server.xml.  We have tried setting the parameter in the ResourceParams section for the
JDBC stanza, like this:
> <ResourceParams name="jdbc/OURDBINSTANCENAME">
>   <parameter>
>       <name>factory</name>
>       <value>org.apache.commons.dbcp.datasources.PerUserPoolDataSourceFactory</value>
>    </parameter>
>    <parameter>
>       <name>defaultReadOnly</name>
>       <value>notset</value>
>    </parameter>
> ...
> </ResourceParams>
> ...with no success.
> It should be noted that previous to discovering this issue, we did not have this parameter
set at all; so I'm not even sure if this is the proper location for this configuration directive.
 I could not find any guidance in the DBCP documentation on where to put this stuff.
> Please advise,
> Josh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message