commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SANDBOX-262) COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)
Date Wed, 07 Jan 2009 06:30:45 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661461#action_12661461
] 

Christian Grobmeier commented on SANDBOX-262:
---------------------------------------------

As discussed here:
http://mail-archives.apache.org/mod_mbox/commons-dev/200810.mbox/%3C07071EEC-C9EB-40B3-B0B1-5D3306BE4013@apache.org%3E

use of reflection might be a bit overkill. The patch from 2009-01-06 10:25 PM eliminates the
reflection stuff from the codebase and makes everything a bit cleaner and easier to use.


> COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-262
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-262
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: Compress
>         Environment: N/A
>            Reporter: Tim Pinet
>         Attachments: ArchiveStreamFactory.patch, patch-improve-factories.txt
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> Reflection handles the checked exceptions for Constructor.newInstance() appropriately
for:
> public ArchiveInputStream createArchiveInputStream( final String archiverName, final
InputStream out ) throws ArchiveException {...}
> However, the other method:
> public ArchiveInputStream createArchiveInputStream( final InputStream input ) throws
IOException {...}
> is not implemented to handle checked constructor exceptions since all Exception catches
are not handled. It looks as though this method was not completed. This method should handle
exceptions similar to its counterpart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message