commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Akolkar (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SCXML-103) Remove any catch (Throwable t) occurences
Date Mon, 05 Jan 2009 20:15:44 GMT

     [ https://issues.apache.org/jira/browse/SCXML-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rahul Akolkar updated SCXML-103:
--------------------------------

    Summary: Remove any catch (Throwable t) occurences  (was: ThreadDeath should not be ignored)

I think this subject for the issue is clearer, but feel free to change if you don't like it.


> Remove any catch (Throwable t) occurences
> -----------------------------------------
>
>                 Key: SCXML-103
>                 URL: https://issues.apache.org/jira/browse/SCXML-103
>             Project: Commons SCXML
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 0.10, 1.0
>
>
> There are a few instances where the code catches Throwable, but fails to rethrow anything.
> For example:
> {code}
> org.apache.commons.scxml.io.SCXMLSerializer.getTransformer()
> ...
>         } catch (Throwable t) {
>             return null;
>         }
> {code}
> It would be safer if the code only caught the relevant Exception(s) (and perhaps some
Errors).
> For example does it really make sense to catch OutOfMemory ?
> In particular, the Javadoc for ThreadDeath says:
> {quote} If ThreadDeath is caught by a method, it is important that it be rethrown so
that the thread actually dies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message