commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (SCXML-103) ThreadDeath should not be ignored
Date Mon, 05 Jan 2009 18:39:44 GMT
ThreadDeath should not be ignored
---------------------------------

                 Key: SCXML-103
                 URL: https://issues.apache.org/jira/browse/SCXML-103
             Project: Commons SCXML
          Issue Type: Bug
            Reporter: Sebb
            Priority: Minor


There are a few instances where the code catches Throwable, but fails to rethrow anything.
For example:

{code}
org.apache.commons.scxml.io.SCXMLSerializer.getTransformer()
...
        } catch (Throwable t) {
            return null;
        }
{code}

It would be safer if the code only caught the relevant Exception(s) (and perhaps some Errors).
For example does it really make sense to catch OutOfMemory ?

In particular, the Javadoc for ThreadDeath says:

{quote} If ThreadDeath is caught by a method, it is important that it be rethrown so that
the thread actually dies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message