commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Akolkar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SCXML-98) TestCases should use SCXMLParser
Date Wed, 03 Dec 2008 22:45:44 GMT

    [ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653019#action_12653019
] 

Rahul Akolkar commented on SCXML-98:
------------------------------------

Thanks for the concrete proposal.
1) Yes, we'd use SCXMLTestHelper#parse() methods instead of corresponding #digest() methods.
The SCXML test documents may need corresponding tweaks as well.
2) Yes, but we already have such a class so we'd change it as needed: http://svn.apache.org/repos/asf/commons/proper/scxml/trunk/src/test/java/org/apache/commons/scxml/io/SCXMLDigesterTest.java
And finally, if its only a couple of tests for the deprecated SCXMLDigester class, I don't
mind the duplicate SCXML documents (obviously, we don't want to go from N documents to 2*N
documents, but N+2 seems OK :-).


> TestCases should use SCXMLParser
> --------------------------------
>
>                 Key: SCXML-98
>                 URL: https://issues.apache.org/jira/browse/SCXML-98
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Ingmar Kliche
>             Fix For: 0.10
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester
is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using
SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message