Return-Path: 
 <issues-return-5852-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-issues-archive@locus.apache.org
Received: (qmail 50608 invoked from network); 21 Nov 2008 17:14:37 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 21 Nov 2008 17:14:37 -0000
Received: (qmail 88131 invoked by uid 500); 21 Nov 2008 17:14:45 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 88040 invoked by uid 500); 21 Nov 2008 17:14:44 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 88012 invoked by uid 99); 21 Nov 2008 17:14:44 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2008 09:14:44 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2008 17:13:29 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 13DF2234C297
	for <issues@commons.apache.org>; Fri, 21 Nov 2008 09:13:45 -0800 (PST)
Message-ID: <835751536.1227287625080.JavaMail.jira@brutus>
Date: Fri, 21 Nov 2008 09:13:45 -0800 (PST)
From: "Ingmar Kliche (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (SCXML-90) event attribute of <send> is not
 evaluated
In-Reply-To: <1703799783.1227193604317.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/SCXML-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649709#action_12649709 ] 

Ingmar Kliche commented on SCXML-90:
------------------------------------

I checked out the fix and run the test cases and it worked for me.

The only question I have: You check whether "event" evaluates to an empty "eventValue":

            if (SCXMLHelper.isStringEmpty(eventValue)
                    && appLog.isWarnEnabled()) {
                appLog.warn("<send>: event expression \"" + event
                    + "\" evaluated to null or empty String");

to log a warning message in this case. Because of a logging a "warning", this case seems to be close to an error (at least when reading the log). But there are certainly valid usecases where the eventname is meaningless, e.g. an HTTP request:

<send target="URL" targettype="basichttp" namelist="some params"/>

In this case the implementation would log a warning. Should an empty eventname be a "info" or "debug" message instead? But this is just a minor comment.

Thanks!

> event attribute of <send> is not evaluated
> ------------------------------------------
>
>                 Key: SCXML-90
>                 URL: https://issues.apache.org/jira/browse/SCXML-90
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Ingmar Kliche
>             Fix For: 0.9
>
>
> The "event"-Attribute of <send> is not evaluated. This is not in line with the SCXML WD.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.