Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <1280341515.1226657444574.JavaMail.jira@brutus>
Date: Fri, 14 Nov 2008 02:10:44 -0800 (PST)
From: "Siegfried Goeschl (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Commented: (EXEC-27) Rename EnvironmentUtil to
 EnvironmentUtils
In-Reply-To: <2069693691.1217070331741.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/EXEC-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647561#action_12647561 ] 

Siegfried Goeschl commented on EXEC-27:
---------------------------------------

The EnvironmentUtil class is part of the original code drop, all other *Utils I wrote. And I'm not really willing to break backward compatibility due to cosmetic name change.

Regarding separation of public class and internal representation

+) no one is reading javadoc to understand such a fine-grained separation between public classes and useful implementation classes
+) to cleanly separate it I personally would create an "impl" package but this is not really an option

As a side note: I'm not too happy with structure and some implementation decisions but I try to stick closely to the original ANT code simply because it is mature and known to work. And retesting the code on the various platforms is a major headache .... :-)

> Rename EnvironmentUtil to EnvironmentUtils
> ------------------------------------------
>
>                 Key: EXEC-27
>                 URL: https://issues.apache.org/jira/browse/EXEC-27
>             Project: Commons Exec
>          Issue Type: Wish
>    Affects Versions: 1.0
>            Reporter: Benjamin Bentmann
>            Assignee: Siegfried Goeschl
>            Priority: Trivial
>         Attachments: EXEC-27.patch
>
>
> Utility classes from exec:
> - {{DebugUtils}}
> - {{MapUtils}}
> - {{StringUtils}}
> - {{EnvironmentUtil}}
> Note that {{EnvironmentUtil}} is the only one using singular form of utility. To make the API consistent, both within exec and compared with other commons libs like collections and lang, I suggest to rename the class to {{EnvironmentUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.