Return-Path: Delivered-To: apmail-commons-issues-archive@locus.apache.org Received: (qmail 56464 invoked from network); 26 Nov 2008 11:33:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Nov 2008 11:33:13 -0000 Received: (qmail 9949 invoked by uid 500); 26 Nov 2008 11:33:18 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 9666 invoked by uid 500); 26 Nov 2008 11:33:17 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 9642 invoked by uid 99); 26 Nov 2008 11:33:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Nov 2008 03:33:16 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Nov 2008 11:31:58 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id EB9C0234C29D for ; Wed, 26 Nov 2008 03:32:44 -0800 (PST) Message-ID: <1196570133.1227699164964.JavaMail.jira@brutus> Date: Wed, 26 Nov 2008 03:32:44 -0800 (PST) From: "Sebb (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (SCXML-91) Test case bugs In-Reply-To: <1910611694.1227607424980.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SCXML-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650962#action_12650962 ] Sebb commented on SCXML-91: --------------------------- 1) OK 2) There is so much output generated that it is possible to overlook the serialisation errors. Also, a lot of this output is expected; it's tedious scanning through all of it. Perhaps a work-round would be to add a single test to check the serialisability of a known problematic class and report that as a failure. SCXMLTestHelper#testExecutorSerializability() should not ignore I/O errors. 3) OK, I discovered this myself later. > Test case bugs > -------------- > > Key: SCXML-91 > URL: https://issues.apache.org/jira/browse/SCXML-91 > Project: Commons SCXML > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Sebb > Fix For: 0.10 > > > Test cases are difficult to debug if they fail. > This is because many test cases catch Exception, and don't report it fully. > Test cases should only catch a (specific) Exception if the test is expected to generate one, and should otherwise throw the Exception. > Several test cases report problems to System.out or System.err and carry on processing. > For example, serialisation errors are largely ignored, and SCXMLTestHelper#testExecutorSerializability() ignores IO errors. > Testing generates a lot of output, some of which appears to be errors (e.g. stack traces) yet the test passes. > Ideally tests should suppress output stack traces which are expected during testing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.