[ https://issues.apache.org/jira/browse/CONFIGURATION-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Heger resolved CONFIGURATION-345.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.6
A fix was applied in revision 712431 (and also ported to the configuration2 branch).
Hm, in "Effective Java" (http://java.sun.com/docs/books/effective/) Joshua Bloch advises against
calling protected non-final methods in constructors. Here we see why.
> PropertiesConfiguration does not use the default encoding to load files
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-345
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-345
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 1.5
> Environment: Win XP / Sun JVM 1.5.0_14
> Reporter: Guillaume Darmont
> Assignee: Oliver Heger
> Fix For: 1.6
>
>
> The piece of code
> {code:title=PropertiesConfiguration.java}
> // initialization block to set the encoding before loading the file in the constructors
> {
> setEncoding(DEFAULT_ENCODING);
> }
> {code}
> seems to set correctly the default encoding, but this block is called after "super()"
in constructors.
> So when using either PropertiesConfiguration(java.io.File file), PropertiesConfiguration(java.lang.String
fileName) or PropertiesConfiguration(java.net.URL url), the super() statement is called, and
it loads the file without the default encoding.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|