Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <54402957.1223668964328.JavaMail.jira@brutus>
Date: Fri, 10 Oct 2008 13:02:44 -0700 (PDT)
From: "Viraj Turakhia (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (LANG-458) Add methods to return boolean from
 Validate.java instead of throwing IllegalArgumentException
In-Reply-To: <1812615181.1221308326204.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viraj Turakhia updated LANG-458:
--------------------------------

    Attachment: validate_test_diff.txt
                vaidate_diff.txt

As per the discussion, attaching diff for code and test file (Validate.java and ValidateTest.java).

Change includes removing code duplication and adding of two utility methods.
Let me know what you think.

> Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
>                 Key: LANG-458
>                 URL: https://issues.apache.org/jira/browse/LANG-458
>             Project: Commons Lang
>          Issue Type: Improvement
>         Environment: software
>            Reporter: Viraj Turakhia
>            Priority: Minor
>         Attachments: vaidate_diff.txt, validate_test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just want to validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>         Validate.notEmpty(list1);
>     } catch(IllegalArgumentException e) {
>         continue;
>     }
> }
> much better approach is:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>     if(! Validate.notEmpty(list1)) {
>         continue;
>     }
> }
> If you all agree with this change, I am willing to submit a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.