Return-Path: Delivered-To: apmail-commons-issues-archive@locus.apache.org Received: (qmail 26741 invoked from network); 9 Oct 2008 20:33:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Oct 2008 20:33:06 -0000 Received: (qmail 62227 invoked by uid 500); 9 Oct 2008 20:33:04 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 62148 invoked by uid 500); 9 Oct 2008 20:33:04 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 62137 invoked by uid 99); 9 Oct 2008 20:33:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2008 13:33:03 -0700 X-ASF-Spam-Status: No, hits=-1999.9 required=10.0 tests=ALL_TRUSTED,DNS_FROM_SECURITYSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2008 20:32:07 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 39FEF234C218 for ; Thu, 9 Oct 2008 13:32:44 -0700 (PDT) Message-ID: <1930191829.1223584364236.JavaMail.jira@brutus> Date: Thu, 9 Oct 2008 13:32:44 -0700 (PDT) From: "Oliver Heger (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (CONFIGURATION-338) PropertiesConfiguration should allow variable interpolation for includes In-Reply-To: <285552241.1223451224691.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CONFIGURATION-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638379#action_12638379 ] Oliver Heger commented on CONFIGURATION-338: -------------------------------------------- Patch applied in revision r703248. Many thanks! (Leaving open until the patch is also applied to the configuration2 branch.) > PropertiesConfiguration should allow variable interpolation for includes > ------------------------------------------------------------------------ > > Key: CONFIGURATION-338 > URL: https://issues.apache.org/jira/browse/CONFIGURATION-338 > Project: Commons Configuration > Issue Type: Improvement > Affects Versions: 1.5 > Reporter: David Donn > Attachments: include-interpolation.patch > > > It would be nice if Include files were subject to the same variable interpolation as regular properties. > e.g. it should be possible to do > include=${sys:myfilename} > I think it is simply a matter of changing the call in to loadIncludeFile() PropertiesConfiguration.propertyLoaded() from: > loadIncludeFile(files[i].trim()); > to: > loadIncludeFile(interpolate(files[i].trim())); > I am happy to submit a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.