commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "J. Lewis Muir (JIRA)" <j...@apache.org>
Subject [jira] Created: (CLI-170) TypeHandler prints messages to stderr
Date Sat, 27 Sep 2008 15:17:44 GMT
TypeHandler prints messages to stderr
-------------------------------------

                 Key: CLI-170
                 URL: https://issues.apache.org/jira/browse/CLI-170
             Project: Commons CLI
          Issue Type: Bug
          Components: CLI-1.x
    Affects Versions: 1.2
            Reporter: J. Lewis Muir
             Fix For: 1.2
         Attachments: remove-messages-to-stderr.patch

Certain methods in {{TypeHandler}} print a message to stderr when they are unable to create
the object they are to return.  I don't think this should be.  The documentation for each
method clearly states that if it is unable to create the object, it returns {{null}}.  If
more information should be reported to the caller, these methods should be changed to throw
an exception.  I've removed the printing of these messages from {{TypeHandler}}.

This fix also makes the unit test output clean.  Right now, certain test cases exercise the
"returns {{null}}" behavior of some of the {{TypeHandler}} methods, and this causes various
error messages to be written to stderr which makes the test case output look unclean and like
something has gone wrong when in fact everything is working correctly.

Attached is a patch for this fix.  The patch is against [http://svn.apache.org/repos/asf/commons/proper/cli/branches/cli-1.x].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message