commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Carman (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-458) Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException
Date Sat, 20 Sep 2008 11:41:45 GMT

    [ https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632937#action_12632937
] 

James Carman commented on LANG-458:
-----------------------------------

Are you an Apache Commons Committer?  If not, then we can't assign it to you.  However, I
would like if some other folks on the Apache Commons team would chime in on this as to whether
they think it's an appropriate addition to the API.  If they're cool with it, I have no problem
applying your patch for you.  Don't worry, you'll get credit since your patch is listed here.
:)

> Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
>                 Key: LANG-458
>                 URL: https://issues.apache.org/jira/browse/LANG-458
>             Project: Commons Lang
>          Issue Type: Improvement
>         Environment: software
>            Reporter: Viraj Turakhia
>            Priority: Minor
>         Attachments: code_diff.txt, test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just want to
validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>         Validate.notEmpty(list1);
>     } catch(IllegalArgumentException e) {
>         continue;
>     }
> }
> much better approach is:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>     if(! Validate.notEmpty(list1)) {
>         continue;
>     }
> }
> If you all agree with this change, I am willing to submit a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message