commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Bourg (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CLI-15) HelpFormatter does not handle groups properly
Date Fri, 25 Jul 2008 08:29:31 GMT

     [ https://issues.apache.org/jira/browse/CLI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Emmanuel Bourg updated CLI-15:
------------------------------

    Component/s:     (was: CLI-2.x)
                 Help formatter
    Environment:     (was: Operating System: All
Platform: All)
        Summary: HelpFormatter does not handle groups properly  (was: [cli] HelpFormatter
does not handle groups properly)

> HelpFormatter does not handle groups properly
> ---------------------------------------------
>
>                 Key: CLI-15
>                 URL: https://issues.apache.org/jira/browse/CLI-15
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: Help formatter
>    Affects Versions: 1.0
>            Reporter: Etienne Pelletier
>             Fix For: 2.0
>
>         Attachments: HelpFormatter.java, Option.java
>
>
> The HelpFormatter repeats Options that have previously been printed with the group.
> The problem is in the else block where options not belonging to a group are
> printed.  The code gets executed if it does not belong to a group -OR- if the
> group has already been printed.
>    if( group != null && !list.contains(group)) {
> // this gets executed when a new group is found
> ...
> } else {
>   // this gets executed if the group is OR ISN'T null, and if group is in list.  
>  ....
> }
> The else statement on line 267 should be as follows:
> } else if (group == null) {
> // This will make sure that options that have not been printed as part of a group
> // will not get printed again.
> ...
> }
> I believe this change fixes the problem.
> Also, the append on line 264 should add an extra space after the ] to make sure
> that there will be a space between the ] and the next option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message