commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Lundberg (JIRA)" <j...@apache.org>
Subject [jira] Moved: (EXEC-20) [exec] EnvironmentVariable: inline private constructor
Date Sat, 28 Jun 2008 05:41:46 GMT

     [ https://issues.apache.org/jira/browse/EXEC-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dennis Lundberg moved SANDBOX-51 to EXEC-20:
--------------------------------------------

    Component/s:     (was: Exec)
            Key: EXEC-20  (was: SANDBOX-51)
        Project: Commons Exec  (was: Commons Sandbox)

> [exec] EnvironmentVariable: inline private constructor
> ------------------------------------------------------
>
>                 Key: EXEC-20
>                 URL: https://issues.apache.org/jira/browse/EXEC-20
>             Project: Commons Exec
>          Issue Type: Bug
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Jerome Lacoste
>            Assignee: Siegfried Goeschl
>         Attachments: 36796_environment_variable_inline_constructor.diff
>
>
> Move the key=value String parsing inside the factory method and remove the
> private constructor.
> There's no need for both and parsing logic is better outside of a constructor
> (as a rule and to make things similar with the rest of the code), especially whe
> n there's already a factory.
> Removing the constructor doesn't create an issue as it's private and there's
> already another private one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message