commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Wareham (JIRA)" <j...@apache.org>
Subject [jira] Created: (VALIDATOR-266) DomainValidator uses an O(n) method where an O(1) would be more appropriate
Date Tue, 17 Jun 2008 11:27:45 GMT
DomainValidator uses an O(n) method where an O(1) would be more appropriate
---------------------------------------------------------------------------

                 Key: VALIDATOR-266
                 URL: https://issues.apache.org/jira/browse/VALIDATOR-266
             Project: Commons Validator
          Issue Type: Bug
          Components: Routines
    Affects Versions: 1.4
            Reporter: Chris Wareham
            Priority: Minor


The class org.apache.commons.validator.routines.DomainValidator contains several hard coded
arrays of TLD names. Quite apart from whether these should be in a properties file rather
than the source file itself, they are then used to populate List instances via Arrays.asList()
and the List.contains() method used when validating a TLD. This is almost inevitably an O(n)
operation on each list, and could be improved by populating a single HashSet which would provide
O(1) performance.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message