commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JXPATH-123) Regression: "fix" made to NamespaceResolver broke existing testcases
Date Thu, 12 Jun 2008 14:34:45 GMT

    [ https://issues.apache.org/jira/browse/JXPATH-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604528#action_12604528
] 

Matt Benson commented on JXPATH-123:
------------------------------------

To follow up, it seems that my approach of maintaining the reverseMap on an ongoing basis
accomplishes what Dmitri was trying to do before--make sure the last registered prefix is
returned for a given URI during reverse lookup.

> Regression:  "fix" made to NamespaceResolver broke existing testcases
> ---------------------------------------------------------------------
>
>                 Key: JXPATH-123
>                 URL: https://issues.apache.org/jira/browse/JXPATH-123
>             Project: Commons JXPath
>          Issue Type: Bug
>    Affects Versions: 1.2 Final
>            Reporter: Matt Benson
>             Fix For: 1.3
>
>
> Relatively shortly after introducing NamespaceResolver, Dmitri had changed it to wipe
out the reverse mapping cache every time a new mapping was added.  The tests, however, relied
upon the last added mapping to a given namespace being the preferred prefix.  The description
for his change was that he was fixing a "bug", but since he didn't elaborate on what kind
of bug I can't see how maintaining the cache is any more harmful than not maintaining it,
and reverting this change clears up the test failures that for some reason are only seen on
JDK 1.3.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message