commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] Created: (LANG-440) DateUtils.round doesn't work correct for Calendar.AM_PM
Date Mon, 02 Jun 2008 20:49:45 GMT
DateUtils.round doesn't work correct for Calendar.AM_PM
-------------------------------------------------------

                 Key: LANG-440
                 URL: https://issues.apache.org/jira/browse/LANG-440
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.4
            Reporter: Robert Scholte
             Fix For: 3.0


The provided JUnit-tests test with wrong expected values
{code:title= original DateUtilsTest.java}
dateAmPm1 = dateTimeParser.parse("February 3, 2002 01:10:00.000");
dateAmPm2 = dateTimeParser.parse("February 3, 2002 11:10:00.000");
dateAmPm3 = dateTimeParser.parse("February 3, 2002 13:10:00.000");
dateAmPm4 = dateTimeParser.parse("February 3, 2002 19:10:00.000");

assertEquals("truncate ampm-1 failed",
                dateTimeParser.parse("February 3, 2002 00:00:00.000"),
                DateUtils.round(dateAmPm1, Calendar.AM_PM));
        assertEquals("truncate ampm-2 failed",
                dateTimeParser.parse("February 4, 2002 00:00:00.000"),
                DateUtils.round(dateAmPm2, Calendar.AM_PM));
        assertEquals("truncate ampm-3 failed",
                dateTimeParser.parse("February 3, 2002 12:00:00.000"),
                DateUtils.round(dateAmPm3, Calendar.AM_PM));
        assertEquals("truncate ampm-4 failed",
                dateTimeParser.parse("February 4, 2002 12:00:00.000"),
                DateUtils.round(dateAmPm4, Calendar.AM_PM));
{code}

but expected values must be

{code}
dateTimeParser.parse("February 3, 2002 00:00:00.000");
dateTimeParser.parse("February 3, 2002 12:00:00.000");
dateTimeParser.parse("February 3, 2002 12:00:00.000");
dateTimeParser.parse("February 4, 2002 00:00:00.000");
{code}

Also in the junit-comment the word 'truncate' must be replaced with 'round'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message