commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Carman (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VFS-196) FTP Provider Does Not Support Symbolic Links Correctly
Date Sat, 24 May 2008 13:05:55 GMT

    [ https://issues.apache.org/jira/browse/VFS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599587#action_12599587
] 

James Carman commented on VFS-196:
----------------------------------

There were some changes to the logic in trunk from when I created this patch.  The trunk had:
\\
\\
{code}
final FTPFile[] tmpChildren = client.listFiles(relPath);
if (tmpChildren == null)
{
    children = null;
}
else if (tmpChildren.length == 0)
{
    children = EMPTY_FTP_FILE_MAP;
}
else
{
    children = new TreeMap();
    ...
{code}
\\
and my code has:
\\
\\
{code} 
final String path = fileInfo != null && fileInfo.isSymbolicLink() ? getFileSystem().getFileSystemManager().resolveName(getParent().getName(),
fileInfo.getLink() ).getPath() : relPath;
final FTPFile[] tmpChildren = client.listFiles(path);
if (tmpChildren == null || tmpChildren.length == 0)
{
    children = EMPTY_FTP_FILE_MAP;
}
else
{
    children = new TreeMap();
    ...
{code}
\\
I don't know if the null case is handled correctly or not.  Please advise.

> FTP Provider Does Not Support Symbolic Links Correctly
> ------------------------------------------------------
>
>                 Key: VFS-196
>                 URL: https://issues.apache.org/jira/browse/VFS-196
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: James Carman
>            Assignee: James Carman
>             Fix For: 1.1, 2.0
>
>         Attachments: symbolic_links.patch
>
>
> If a directory is a symbolic link, it shows up as file type "imaginary"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message