commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rory Winston (JIRA)" <j...@apache.org>
Subject [jira] Commented: (NET-208) TelnetInputStream swallows interruptedexception as IOException
Date Fri, 16 May 2008 20:53:55 GMT

    [ https://issues.apache.org/jira/browse/NET-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597609#action_12597609
] 

Rory Winston commented on NET-208:
----------------------------------

Hi Sebb

Indeed it should - I just tentatively wanted to make sure that IIOE was present pre JDK-1.5,
which I didnt have the opportunity to check at the time. Looks like its been there since the
beginning!

> TelnetInputStream swallows interruptedexception as IOException
> --------------------------------------------------------------
>
>                 Key: NET-208
>                 URL: https://issues.apache.org/jira/browse/NET-208
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Jan Van Besien
>             Fix For: 1.5, 2.0
>
>
> The TelnetInputStream catches InterruptedException in the read() method (line 342) and
throws a new IOException without wrapping the InterruptedException. This means that the fact
that the read() method was interrupted can hardly be distinguished from any other IOException.
> I use thread interruption as a cancellation mechanism for a thread that uses the TelnetInputStream
to read data.
> The read method is not allowed to throw InterruptedException, so I propose to fix it
by at least wrapping the underlying InterruptedException:
> catch (InterruptedException e)
> {
>     throw new IOException("Fatal thread interruption during read.", e);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message