commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-158) ReaderInputStream implementation
Date Wed, 28 May 2008 21:56:45 GMT

    [ https://issues.apache.org/jira/browse/IO-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600620#action_12600620
] 

Matt Benson commented on IO-158:
--------------------------------

Looking pretty good given my limited experience with nio.  [io] is moving to Java 5, so no
worries there.  The javadoc is a little unclear for my liking, but my understanding is that
a newly-created or reset() CharsetEncoder will, in the case of UTF-16, write the byte order
before its first encode() operation, and that the corresponding CharsetDecoder (UTF-16, fresh
state) would similarly expect the byte order info before any actual data?  The only other
thing I would like to see, beyond the missing unit test, is complete javadoc including a note
to the effect that these classes are not safe for use from multiple threads.

> ReaderInputStream implementation
> --------------------------------
>
>                 Key: IO-158
>                 URL: https://issues.apache.org/jira/browse/IO-158
>             Project: Commons IO
>          Issue Type: Wish
>            Reporter: Andreas Veithen
>            Priority: Minor
>         Attachments: IO-158.patch.txt
>
>
> The standard Java class InputStreamReader converts a Reader into an InputStream. In some
cases it is necessary to do the reverse, i.e. to convert a Reader into an InputStream. Several
frameworks and libraries have their own implementation of this functionality (google for "ReaderInputStream").
Among these are at least four Apache projects: Ant, iBatis, James and XMLBeans. Commons IO
would be a good place to share a common implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message