commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-167) Fix case-insensitive string handling
Date Fri, 30 May 2008 17:06:45 GMT

    [ https://issues.apache.org/jira/browse/IO-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601197#action_12601197
] 

Benjamin Bentmann commented on IO-167:
--------------------------------------

bq. add a new checkIndexOf() method to IOCase
Extending {{IOCase}} in this way seems consequent to me. I have only some minor wishes remaining:
- Add a @since tag to the newly added method
- Extend the {{IOCaseTestCase}} to check for proper handling of case-insensitivity with Non-ASCIIs
and guard against regressions of this issue.  You should be able to simply copy the code from
{{FilenameUtilsWildcardTestCase.testLocaleIndependence()}} (which is hopefully integrated
nevertheless) around and change one or two lines to test {{checkIndexOf()}}.

Niall's patch in place, {{IOCase.convertCase()}} seems unused and could be deleted.

> Fix case-insensitive string handling
> ------------------------------------
>
>                 Key: IO-167
>                 URL: https://issues.apache.org/jira/browse/IO-167
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Benjamin Bentmann
>             Fix For: 2.0
>
>         Attachments: IO-167-a.patch, IO-167-checkIndexOf.patch, IO-167.patch, IO-167.patch
>
>
> Case-insensitive operations are currently platform-dependent, please see [Common Bug
#3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html] for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message