Return-Path: Delivered-To: apmail-commons-issues-archive@locus.apache.org Received: (qmail 46177 invoked from network); 12 Mar 2008 20:22:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Mar 2008 20:22:20 -0000 Received: (qmail 92339 invoked by uid 500); 12 Mar 2008 20:22:15 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 92271 invoked by uid 500); 12 Mar 2008 20:22:15 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 92261 invoked by uid 99); 12 Mar 2008 20:22:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2008 13:22:15 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2008 20:21:46 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 29E2A234C0AB for ; Wed, 12 Mar 2008 13:20:47 -0700 (PDT) Message-ID: <436212506.1205353247170.JavaMail.jira@brutus> Date: Wed, 12 Mar 2008 13:20:47 -0700 (PDT) From: "Sebb (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (NET-188) FTPClient#listFiles returns null element when file's timestamp is "02/29" In-Reply-To: <1838758804.1203934971378.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/NET-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated NET-188: --------------------- Attachment: FTPTimestampParserLeap.patch Patch which appears to solve the Feb 29 problem on Java 1.4. Can also be applied to NET_2.0 branch if desired. The patch changes the processing so the short form is always parsed with the current year appended. So the short form format string(s) could potentially be changed to include the year. > FTPClient#listFiles returns null element when file's timestamp is "02/29" > ------------------------------------------------------------------------- > > Key: NET-188 > URL: https://issues.apache.org/jira/browse/NET-188 > Project: Commons Net > Issue Type: Bug > Affects Versions: 1.4 > Reporter: HONMA Hirotaka > Attachments: commons-net-ftp-date-parser-feb29.patch, DstParseTest.java, FTPTimestampParserLeap.patch > > > This issue has same cause as VALIDATOR-221. > org.apache.commons.net.ftp.parser.FTPTimestampParserImpl#parseTimestamp throws ParseException with timestampStr = "Feb 29 11:22". > FTP Server status: > {code} > [root@localhost test-commonsnet]# pwd > /tmp/test-commonsnet > [root@localhost test-commonsnet]# ls -l > total 0 > -rw-r--r-- 1 root root 0 Dec 19 2006 aaa.txt > -rw-r--r-- 1 root root 0 Feb 29 11:22 bbb.txt > {code} > test code: > {code} > public void testCommonsNetLeapDay() throws Exception { > final FTPClient ftp = new FTPClient(); > ftp.connect(host); > ftp.login(user, password); > final FTPFile[] listFiles = ftp.listFiles("/tmp/test-commonsnet"); > for (int i = 0; i < listFiles.length; i++) { > System.out.println("[" + i + "] " + listFiles[i]); > } > ftp.disconnect(); > } > {code} > results bellow. > {code} > [0] -rw-r--r-- 1 0 0 0 Dec 18 2006 aaa.txt > [1] null > {code} > Second element(bbb.txt) should not be null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.