commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Armbrust (JIRA)" <j...@apache.org>
Subject [jira] Commented: (NET-187) TFTP Server for commons net
Date Fri, 07 Mar 2008 14:39:46 GMT

    [ https://issues.apache.org/jira/browse/NET-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576213#action_12576213
] 

Dan Armbrust commented on NET-187:
----------------------------------

Well, now that we have a Dilbert manager in the conversation, we can be sure that we wont
let good code get in the way of a good mission statement.

James, I really don't see why you are so worried.  As far as I can tell from recent bugs,
_you_ haven't been maintaining anything WRT the TFTP code.  So, I really don't see that adding
one more class is going to increase your burden any.  And the TFTP code has been quite seriously
broken in recent releases, mostly because properly testing the code is a pain when you don't
have a TFTP server set up.  Now you have a TFTP server that is easy to use, and JUnit tests
which verify operation of the server and the client.

A POP3 server and an HTTP server are examples of _much_ more complex servers.  A TFTP server
is hardly on the same scale.  Like I mentioned before, what we have here is a single class
that runs a TFTP server.  It requires no changes to other commons net code, and no one is
forcing anyone else to use it.  Nobody is asking commons-net developers to write one.  As
far as maintenance concerns, I've usually found testable code is much easier to maintain that
non-testable code.  But hey, if you want to go back to having not-easily-testable tftp client
code, go right ahead.  

As a "customer" of commons-net - this is where I would expect to find a TFTP server.  Do you
really thing that something as simple as a TFTP server should be a top-level apache project,
on par with a HTTP server or a Tomcat server?  Even the notion of a "commmons-tftp-server"
project is pretty silly, given the size and simplicity of the thing.  But if someone offers
to set up such a sub-project for it, I'll put it there and maintain it.  But I'm not going
to do the legwork for it myself - I'll just go throw it out on google code if nothing else.


In the end, its not my project.  Do what you want.  I'm willing to fix the compiling issue
on 1.2 - and provide a new patch - it was a simple oversight.  But I'm not going to waste
any more time on it if you are just going to throw the code away, or bury it in your test
code.





> TFTP Server for commons net 
> ----------------------------
>
>                 Key: NET-187
>                 URL: https://issues.apache.org/jira/browse/NET-187
>             Project: Commons Net
>          Issue Type: New Feature
>    Affects Versions: 1.4
>            Reporter: Dan Armbrust
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: TFTPServer and Tests.patch
>
>
> Bug for attaching TFTP Server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message