Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <33041161.1201984328805.JavaMail.jira@brutus>
Date: Sat, 2 Feb 2008 12:32:08 -0800 (PST)
From: "Phil Steitz (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (POOL-122) java.util.Timer in EvictionTimer does
 not recover from OutOfMemoryError in Evictor
In-Reply-To: <4864639.1201968136512.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/POOL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated POOL-122:
-----------------------------

    Affects Version/s: 1.4
        Fix Version/s: 1.5

I agree with Mark that swallowing Throwable here is not a good idea, so am also -1 on the patch.

Assigning fix version 1.5 and leaving open because we should log the error.

Also affects 1.4, since behavior there is the same.  One more comment I have on this is that while we need to and will continue to support the Evictor, heavily loaded applications should be careful depending on it as a pseudo-garbage collector.  OOME's could indicate resource leaks and these should be investigated and addressed directly (assuming that is contributing to the problem).

> java.util.Timer in EvictionTimer does not recover from OutOfMemoryError in Evictor
> ----------------------------------------------------------------------------------
>
>                 Key: POOL-122
>                 URL: https://issues.apache.org/jira/browse/POOL-122
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 1.4
>         Environment: any
>            Reporter: Marcus Schulte
>             Fix For: 1.5
>
>         Attachments: fixes_POOL-122.patch
>
>
> GenericKeyedObjectPool.Evictor.run() catches and ignores Exceptions, but not Errors, like OOME. Consequently, when, due to load-peeks an OOME is thrown in the evictor's timer-thread it dies miserably and no eviction will happen again in any of the pools loaded within the same class-loader (because the eviction timer is a static member). Also, the creation of evicting pools will fail with IllegalStateException.
> Possible fixes:
>    1. catch Throwable in GenericKeyedObjectPool.Evictor.run()
>    2. check and eventually re-instantiate the Eviction-Timer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.