commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JXPATH-114) node() implementation in DOM and JDOM model
Date Sat, 02 Feb 2008 23:18:13 GMT

     [ https://issues.apache.org/jira/browse/JXPATH-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Benson resolved JXPATH-114.
--------------------------------

    Resolution: Fixed

After quite some analysis, I agree with your findings, Michele.  This is fixed with svn commit
 617923.

> node() implementation in DOM and JDOM model
> -------------------------------------------
>
>                 Key: JXPATH-114
>                 URL: https://issues.apache.org/jira/browse/JXPATH-114
>             Project: Commons JXPath
>          Issue Type: Bug
>            Reporter: Michele Vivoda
>            Priority: Minor
>
> I think that the code in DOMNodePointer.java, line 120 is wrong because considers only
element and document to be matched by node().
> while instead it matches any node that pass from there.
> case Compiler.NODE_TYPE_NODE :
>                     return nodeType == Node.ELEMENT_NODE
>                             || nodeType == Node.DOCUMENT_NODE;
> should be changed to 
> case Compiler.NODE_TYPE_NODE :
>                     return true;
> Same in JDOMNodePointer, line 391
>                   return true;//(node instanceof Element) || (node instanceof Document);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message