commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-183) Findbugs Report
Date Fri, 01 Feb 2008 23:57:09 GMT

    [ https://issues.apache.org/jira/browse/MATH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564982#action_12564982
] 

Sebb commented on MATH-183:
---------------------------

OK.

However, I suggest that the floating point equality tests should be commented in the actual
code, as it's an unusual idiom.

As to synchronisation, it depends partly on whether the Math classes are intended to be thread-safe
or not.

> Findbugs Report
> ---------------
>
>                 Key: MATH-183
>                 URL: https://issues.apache.org/jira/browse/MATH-183
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: MathFindbugs.csv
>
>
> The attachment (to follow) is a summary of a Findbugs run.
> It's possible that the use of == for comparing floats is intended; if so perhaps it should
be commented.
> I think all the other bug reports are valid, though of course the ones relating to the
exposure of internal implementation may be ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message