commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip May (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MODELER-29) Improve the reusability and separation of concerns
Date Wed, 20 Feb 2008 09:44:43 GMT

     [ https://issues.apache.org/jira/browse/MODELER-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Philip May updated MODELER-29:
------------------------------

    Description: 
The level of reusability and the separation of concerns of some classes is insufficient. 
I would like to reuse the MbeansDescriptorsDOMSource class to parse some xml and to build
the MBean stuff.
To do this I have to call the MbeansDescriptorsDOMSource#loadDescriptors( Registry registry,
String location, String type, Object source) method.
To call this method I must have registry, location and type. These references are not even
needed in the class and could be removed.

MbeansDescriptorsDOMSource and the other ModelerSource classes do need some refactoring to
make them reusable.

When I am looking at the code of commons.modeler somehow I get the impression that this commons
component is just made for tomcat and not
for the usage in other projects. Registry id the entry (main) class of commons.modeler. But
it could and should be possible to reuse the other classes
like the parser too.

  was:
The level of reusability and the separation of concerns of some classes is insufficient. 
I would like to reuse the MbeansDescriptorsDOMSource class to parse some xml and to build
the MBean stuff.
To do this I have to call the MbeansDescriptorsDOMSource#loadDescriptors( Registry registry,
String location, String type, Object source) method.
To call this method I must have registry, location and type. These references are not even
needed in the class and could be removed.

MbeansDescriptorsDOMSource and the other ModelerSource classes do need some refactoring to
make them reusable.

When I am looking at the code of commons.modeler somehow I get the impression that this commons
component is just made for tomcat and not
for the usage in other projects.


> Improve the reusability and separation of concerns
> --------------------------------------------------
>
>                 Key: MODELER-29
>                 URL: https://issues.apache.org/jira/browse/MODELER-29
>             Project: Commons Modeler
>          Issue Type: Improvement
>            Reporter: Philip May
>
> The level of reusability and the separation of concerns of some classes is insufficient.

> I would like to reuse the MbeansDescriptorsDOMSource class to parse some xml and to build
the MBean stuff.
> To do this I have to call the MbeansDescriptorsDOMSource#loadDescriptors( Registry registry,
String location, String type, Object source) method.
> To call this method I must have registry, location and type. These references are not
even needed in the class and could be removed.
> MbeansDescriptorsDOMSource and the other ModelerSource classes do need some refactoring
to make them reusable.
> When I am looking at the code of commons.modeler somehow I get the impression that this
commons component is just made for tomcat and not
> for the usage in other projects. Registry id the entry (main) class of commons.modeler.
But it could and should be possible to reuse the other classes
> like the parser too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message