commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trejkaz (JIRA)" <>
Subject [jira] Commented: (SANDBOX-218) CSV reader doesn't handle older Mac line endings
Date Thu, 28 Feb 2008 22:49:51 GMT


Trejkaz commented on SANDBOX-218:

ExtendedBufferedReader is full of redundancy also.  It adds line number counting to BufferedReader,
where it should be extending LineNumberReader if it wants that.  It implements character look-ahead
by implementing its own internal buffer, where it should be using mark(1) and reset().  And
it has a skipUntil method which appears to be completely unused by the parsing code.

> CSV reader doesn't handle older Mac line endings
> ------------------------------------------------
>                 Key: SANDBOX-218
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: CSV
>            Reporter: Trejkaz
>         Attachments: SANDBOX-218.patch
> Older Mac OS line endings which just have \r don't get treated as line endings by the
current CSV parser.
> Most likely the simplest way to get around this is to delegate to a BufferedReader to
reuse its line ending code.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message