commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Michaux (JIRA)" <j...@apache.org>
Subject [jira] Created: (DBCP-258) [PATCH] ManualPoolingDriverExample - more direct construction of driver and minor comment fix
Date Mon, 21 Jan 2008 20:32:36 GMT
[PATCH] ManualPoolingDriverExample - more direct construction of driver and minor comment fix
---------------------------------------------------------------------------------------------

                 Key: DBCP-258
                 URL: https://issues.apache.org/jira/browse/DBCP-258
             Project: Commons Dbcp
          Issue Type: Improvement
    Affects Versions: 1.2.2
            Reporter: Peter Michaux
            Priority: Minor


This example has a very indirect way of registering the driver and getting it from the DriverManager.

  Class.forName("org.apache.commons.dbcp.PoolingDriver");
  PoolingDriver driver = (PoolingDriver) DriverManager.getDriver("jdbc:apache:commons:dbcp:");

It is much more direct and clearer to do the following

  PoolingDriver driver = new PoolingDriver();
  DriverManager.registerDriver(driver);

-------

There were some missing backslashes in the comments about running the example

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message