commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-153) FileWriter that accepts an encoding
Date Sun, 06 Jan 2008 21:37:34 GMT

    [ https://issues.apache.org/jira/browse/IO-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556430#action_12556430
] 

Stephen Colebourne commented on IO-153:
---------------------------------------

* The non-encoding parameters exist as I copied it from LocakbleFileWriter. While it could
be argued that having the constructors allows a single class to be used for all purposes,
I think that removing the no-encoding constructors is probably sensible.
* The constructor uses file.getAbsolutePath() for JDK1.3 compatability.
* I'm not sure that anything is gained by subclassing ProxyWriter (in fact it is more complex)
- what we really want is to subclass FileWriter, but I can't see a way to do that.
* I wanted this to be JDK1.3 compatible. I would hope that the next release will be Java 5
after all ;-)


> FileWriter that accepts an encoding
> -----------------------------------
>
>                 Key: IO-153
>                 URL: https://issues.apache.org/jira/browse/IO-153
>             Project: Commons IO
>          Issue Type: New Feature
>          Components: Streams/Writers
>            Reporter: Stephen Colebourne
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: FileWriterWithEncoding.java, io-FileWriterWithEncoding.patch
>
>
> Amazingly, even in JDK6 there are no constructors on FileWriter that accept an encoding.
> Attached is a patch to add FileWriterWithEncoding

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message