commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michele Vivoda (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JXPATH-105) BasicNodeSet.getNodes() returns values instead of nodes ?
Date Mon, 10 Dec 2007 20:51:43 GMT

    [ https://issues.apache.org/jira/browse/JXPATH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550180
] 

Michele Vivoda commented on JXPATH-105:
---------------------------------------

No, I just went through the code and saw it as a possible bug. From the documentation one
would expect the method to return nodes and not values. I think also that the private member
{nodes} would be just a duplicate of {values} with the current code. If this is ok, getNodes()
 could return getValues() to be more clear. 

> BasicNodeSet.getNodes() returns values instead of nodes ?
> ---------------------------------------------------------
>
>                 Key: JXPATH-105
>                 URL: https://issues.apache.org/jira/browse/JXPATH-105
>             Project: Commons JXPath
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>         Environment: ALL
>            Reporter: Michele Vivoda
>            Priority: Minor
>
> In BasicNodeSet the method getNodes()  
> adds the values instead of the nodes, using  
> nodes.add(pointer.getValue()); 
> instead of  what I think correct:
> nodes.add(pointer.getNode());
> Michele Vivoda
>            

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message