commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Updated: (BEANUTILS-295) Unnecessary Garbage Objects in Class PropertyUtilsBean
Date Wed, 12 Dec 2007 00:54:43 GMT

     [ https://issues.apache.org/jira/browse/BEANUTILS-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Niall Pemberton updated BEANUTILS-295:
--------------------------------------

    Fix Version/s: 1.8.0

Apologies for the slow response.

Although you're right that null arguments works nothing in the JDK API indicates whether the
arguments can be null or not - so IMO would be better to pass a zero length array - however
that doesn't have to be created each time and could be a static singleton instance.

Any chance of a patch for this?


> Unnecessary Garbage Objects in Class PropertyUtilsBean
> ------------------------------------------------------
>
>                 Key: BEANUTILS-295
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-295
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.8.0-BETA
>            Reporter: Stefan Wohlgemuth
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: profiling.png
>
>
> In class PropertyUtilsBean there are several places where the following statement is
called:
> Object value = invokeMethod(readMethod, bean, new Object[0]);
> The statement could be replace with the following statement, whithout creating the unused
Object array (as we know invoke will be called of a method without method parameters):
> Object value = invokeMethod(readMethod, bean, null);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message