commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-147) Deletion of orphaned Softlinks does not work
Date Tue, 18 Dec 2007 18:20:43 GMT

    [ https://issues.apache.org/jira/browse/IO-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552844
] 

Niall Pemberton commented on IO-147:
------------------------------------

Looking back thru the svn history this is the way it originally worked and the file.exists()
check was added in r140382 [1] back in August 2003 (before IO 1.0 was released) - looking
at the Bugzilla tickets 22075 (IO-62) and 22332 (IO-55) referenced in the log message there
is no mention of this change - so it looks like it slipped in without explanation.

I guess the main reasoning is that it allows people using that method to distinguish between
files which don't exist(FileNotFoundException) and other problems(IOException) when trying
to delete. If we remove that check as you suggest then any application relying on a FileNotFoundException
being thrown for non-existant files will break.

[1] http://svn.apache.org/viewvc?view=rev&revision=140382

> Deletion of orphaned Softlinks does not work
> --------------------------------------------
>
>                 Key: IO-147
>                 URL: https://issues.apache.org/jira/browse/IO-147
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 1.3.2
>         Environment: Debian Linux JDK 1.5
>            Reporter: Stefan Lischke
>            Priority: Critical
>
> If there is an orphaned softlink a -> b, but b does not exists anymore than the softlink
will not be removed. This happens when you call FileUtils.deleteDirectory() and when the linked
target b is deleted earlier than the link.
> This is caused by the "ugly" file.exists() call in forceDelete()
> if (!file.exists()) {
>          throw new FileNotFoundException("File does not exist: " + file);
> }
> if this check is not done, everything works as expected. I think this test is not neccessery,
cause file.delete will test this better.
> Please discuss and change this.
> thanx
> Stefan 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message