commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (IO-148) IOException with constructors which take a cause
Date Sat, 22 Dec 2007 01:31:43 GMT

    [ https://issues.apache.org/jira/browse/IO-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554078
] 

ggregory@seagullsw.com edited comment on IO-148 at 12/21/07 5:31 PM:
-----------------------------------------------------------

Hello:

I've added the Throwable constructor as suggested in the previous comment. Thank you Niall
for pointing this out. 

To address your comments:

- If you want to add credits for someone else's inspiration, feel free to add an @author tag.
IMHO, the SVN gymnatics of getting the copy of the file for its SVN history is not worth it
(not so H perhaps ;-) It is not like there is an algorithm to credit here, this is just boiler
plate code. It could be stamped out for every Exception that does not have a throwable constructor
in the SDK.

- I am of the opinion that adding a String constructor is just adding cruft to the library.
It does not provide any additional value to IOException. Callinf such a constructor would
in fact cause call sites to add cruft themsleves since IOException could be used as easlily.
In the teeming masses insist then... of course add it in :-)

      was (Author: ggregory@seagullsw.com):
    Hello:

I've added the Throwable constructor as suggested in the previous comment. Thank you Niall
for pointing this out. 

To address your comments:

- If you want to add credits for someone else's inspiration, feel free to add an @author tag.
IMHO, the SVN gymnatics of getting the copy of the file for its SVN history is not worth it
(not so H perhaps ;-) It is not like there is an algorithm to credit here, this is just boiler
plate code. It could be stamped out for every Exception that does not have a throwable constructor
in the SDK.

- I am of the opinion that adding a String constructor is just adding cruft to the library.
It does not provide any additional value to IOException. Using such a method would in fact
cause call sites to instruct cruft themsleves since IOException could be used. In the teeming
masses insist then... of course add it in :-)
  
> IOException with constructors which take a cause
> ------------------------------------------------
>
>                 Key: IO-148
>                 URL: https://issues.apache.org/jira/browse/IO-148
>             Project: Commons IO
>          Issue Type: New Feature
>            Reporter: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.4
>
>
> Add an IOException implementation that has constructors which take a cause (see TIKA-104).
Constructors which take a cause (Throwable) were not added to IOException until JDK 1.6 but
the initCause() method  was added to Throwable in JDK 1.4.
> We should copy the Tika implementation and test case here:
> http://svn.apache.org/repos/asf/incubator/tika/trunk/src/main/java/org/apache/tika/exception/CauseIOException.java
> http://svn.apache.org/repos/asf/incubator/tika/trunk/src/test/java/org/apache/tika/exception/CauseIOExceptionTest.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message