commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <>
Subject [jira] Updated: (LANG-374) Add escaping for CSV columns to StringEscapeUtils
Date Thu, 27 Dec 2007 07:31:43 GMT


Henri Yandell updated LANG-374:

    Attachment: LANG-374-unescape.patch

Attaching an unescape method. I think there's no reason not to have the symmetry.

We should avoid the generic delimiters I believe as it's too deep a path to walk down; different
escaping strategies and quoting. 

There is one odd case in the unescape method to decide upon. If the value being unescape is:


then should the unescaped version be, or "".

It's not a legal output from the escape method. Reversing the logic in escape() would imply
it should be "", however if it's a different escape method being used that always wraps
in quotes, then returning would be more helpful.


The patch does the "" return currently. 

> Add escaping for CSV columns to StringEscapeUtils
> -------------------------------------------------
>                 Key: LANG-374
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 2.3
>            Reporter: Niall Pemberton
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 2.4
>         Attachments: Lang-374-escapeCsv-v2.patch, LANG-374-escapeDelimited.patch, LANG-374-unescape.patch,
StringEscapeUtils_v3.patch, StringEscapeUtilsTest_v3.patch
> Add escaping for CSV columns to StringEscapeUtils.
> Further information on CSV columns available here:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message