commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (IO-136) HexDump's use of static StringBuffers isn't thread-safe
Date Tue, 20 Nov 2007 12:36:44 GMT

     [ https://issues.apache.org/jira/browse/IO-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Niall Pemberton resolved IO-136.
--------------------------------

    Resolution: Fixed

Fixed http://svn.apache.org/viewvc?view=rev&revision=596642

> HexDump's use of static StringBuffers isn't thread-safe
> -------------------------------------------------------
>
>                 Key: IO-136
>                 URL: https://issues.apache.org/jira/browse/IO-136
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 1.3.2
>            Reporter: Niall Pemberton
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.4
>
>
> HexDump has two private static dump() method's that alter static instances of StringBuffer:
> dump(long) modifies static StringBuffer variable _lbuffer returning _lbuffer 
> dump(char) modifies static StringBuffer variable _cbuffer returning _cbuffer
> Both these methods are called by the public static dump(byte[], long, OutputStream, int)
method. Multiple threads calling the public dump method at the same time could cause these
StringBuffer to contain mixed up data and result in a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message