commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <>
Subject [jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL
Date Tue, 06 Nov 2007 20:35:50 GMT


Niall Pemberton commented on VALIDATOR-248:

I guess the question is does it need to be an option - or should it always be valid? If the
latter then we could just incorporate it into the DomainValidator's validation. Having said
that the way Sergey's done his patch we could do both:

    public boolean isValid(String domain) {
        if (isLocalhost(domain)) {
            return true;
        String[] groups = domainRegex.match(domain);
        if (groups != null && groups.length > 0) {
            return isValidTld(groups[0]);
        } else {
            return false;

> Add an option to allow 'localhost' as a valid hostname part in the URL
> ----------------------------------------------------------------------
>                 Key: VALIDATOR-248
>                 URL:
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.1 Release
>            Reporter: Sergey Nebolsin
>            Assignee: Ben Speakmon
>             Fix For: 1.4
>         Attachments: commons-validator-allow-localhost-r592416.patch
> Working on Grails we've discovered ( that
commons-validator's UrlValidator rejects URLs like "http://localhost:8080/tau_gwi_00/clif/cb/19".
I looked at commons-validator sources and found that any URL which contains 'localhost' as
it's hostname part will be rejected.
> RFC-2396 ( accepts 'localhost' as a valid hostname
(appendix G.3 paragraph 2 says that explicitly).
> So, it would be good to have additional option (UrlValidator.ALLOW_LOCALHOST) which will
control UrlValidator behavior on localhost URLs.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message