commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Speakmon (JIRA)" <>
Subject [jira] Resolved: (VALIDATOR-220) EmailValidator fails with ArrayIndexOutOfBoundsException on domain names longer than 10 segments
Date Thu, 01 Nov 2007 04:49:50 GMT


Ben Speakmon resolved VALIDATOR-220.

    Resolution: Fixed

Resolving since the new EmailValidator is complete and is verified not to suffer from this

> EmailValidator fails with ArrayIndexOutOfBoundsException on domain names longer than
10 segments
> ------------------------------------------------------------------------------------------------
>                 Key: VALIDATOR-220
>                 URL:
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.3.0 Release, 1.3.1 Release
>         Environment: $ uname -a
> Linux frisky 2.6.17-10-generic #2 SMP Tue Dec 5 22:28:26 UTC 2006 i686 GNU/Linux
>            Reporter: Adam Gordon
>            Assignee: Niall Pemberton
>             Fix For: 1.4
> The EmailValidator class, specifically, the "protected boolean isValidSymbolicDomain(String
domain)" method makes an assumption on the PERL RegEX rules, specifically, that no more than
10 domains/subdomains may be specified in an email address.  I.e. an email address of ""
is valid according to the EmailValidator whereas an email address of ""
causes isValidSymbolicDomain(String) to throw an ArrayIndexOutOfBoundsException because the
"domainSegment" local variable is hard-coded to have a length of 10.  
> Whether or not this is due to a limitation in PERL w.r.t. the maximum number of allowed
groupings, I do not know, but the RFC for email addresses does not appear to specify a maximum
number.  Additionally, although I couldn't find it in the RFC, Wikipedia says that the maximum
number of characters for the domain name is 255 - though I am very hesitant to cite/use Wikipedia
as an official source...
> Granted, I've never seen a domain name w/ more than 5 subdomain names, let alone 10,
but it seems like it should be supported regardless.
> I'd submit a patch, but I wanted to discuss possible courses of action and determine
the "right" (or at least acceptable) one.  Possible solutions are:
> 1.  check if the counter i in the for loop is > 10 and perform some action that stops
the iterative process.
> 2.  if the max number of groupings in PERL RegEX is 10, maybe we shouldn't use RegEX
to determine the groupings.
> 3.  if, per the RFC, the max number of domain name groupings is 10, then the code should
check for this.
> Please let me know if you 1) have an alternative solution and 2) want me to code a/the

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message