commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Speakmon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-369) ExceptionUtils not thread-safe
Date Mon, 12 Nov 2007 19:46:51 GMT

    [ https://issues.apache.org/jira/browse/LANG-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541917
] 

Ben Speakmon commented on LANG-369:
-----------------------------------

Patch looks safe.

> ExceptionUtils not thread-safe
> ------------------------------
>
>                 Key: LANG-369
>                 URL: https://issues.apache.org/jira/browse/LANG-369
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 2.4
>
>         Attachments: LANG-369.patch
>
>
> The ExceptionUtils class does not appear to be thread-safe:
> - CAUSE_METHOD_NAMES is not final, so may not be visible to all threads
> - addCauseMethodName() and removeCauseMethodName() can update CAUSE_METHOD_NAMES but
are not synch.
> - all accesses to CAUSE_METHOD_NAMES probably need to be synchronised
> The documentation does not state whether or not the class is thread-safe, but given that
it only has static methods it does not make any sense unless it is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message