[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542529
]
Ben Speakmon commented on VALIDATOR-248:
----------------------------------------
I forgot about RegexValidator being able to contain multiple patterns, so that's a no-brainer.
Your approach is simpler, so I'm +1 on that too.
> Add an option to allow 'localhost' as a valid hostname part in the URL
> ----------------------------------------------------------------------
>
> Key: VALIDATOR-248
> URL: https://issues.apache.org/jira/browse/VALIDATOR-248
> Project: Commons Validator
> Issue Type: Improvement
> Components: Routines
> Affects Versions: 1.3.1 Release
> Reporter: Sergey Nebolsin
> Assignee: Ben Speakmon
> Fix For: 1.4
>
> Attachments: commons-validator-allow-localhost-r592416.patch, commons-validator-allow-non-iana-tlds-r592416.patch,
VALIDATOR-248-refactoring.patch
>
>
> Working on Grails we've discovered (http://jira.codehaus.org/browse/GRAILS-1692) that
commons-validator's UrlValidator rejects URLs like "http://localhost:8080/tau_gwi_00/clif/cb/19".
I looked at commons-validator sources and found that any URL which contains 'localhost' as
it's hostname part will be rejected.
> RFC-2396 (http://www.ietf.org/rfc/rfc2396.txt) accepts 'localhost' as a valid hostname
(appendix G.3 paragraph 2 says that explicitly).
> So, it would be good to have additional option (UrlValidator.ALLOW_LOCALHOST) which will
control UrlValidator behavior on localhost URLs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|