commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Speakmon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package
Date Fri, 02 Nov 2007 20:17:50 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539691
] 

Ben Speakmon commented on VALIDATOR-242:
----------------------------------------

The stripComments() is going to be hard to deal with. That regexp makes me want to cry --
and it doesn't have any tests either. I suppose the right thing to do is add some dedicated
tests for it and then try to untangle the regexp into smaller parts. Pain in the butt :)

As for compiling patterns ahead of time, I agree that it's threadsafe; I held off on it just
to minimize the scope of the change I was making. No problem to do it now though. I'll do
the same thing for UrlValidator.

> Move EmailValidator to routines package
> ---------------------------------------
>
>                 Key: VALIDATOR-242
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-242
>             Project: Commons Validator
>          Issue Type: Task
>          Components: Framework, Routines
>    Affects Versions: 1.3.1 Release
>            Reporter: Ben Speakmon
>            Assignee: Ben Speakmon
>             Fix For: 1.4
>
>
> Move EmailValidator and associated tests to the routines package as part of its refactoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message