commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <>
Subject [jira] Reopened: (VALIDATOR-242) Move EmailValidator to routines package
Date Fri, 02 Nov 2007 13:43:51 GMT


Niall Pemberton reopened VALIDATOR-242:


Firstly, great work on re-factoring both URL and Email validators - including extracting out
the new IntetAddress and domain validators :) thanks!

I'm re-opening this because Email validator still has a dependency on Jakarta ORO with its
use of Perl5Util in the Strip comments.

Also IMO it should improve performance if the regular expressions are not compiled for each
email address validated. The JavaDoc for java.util.regex.Pattern[1] indicates that patterns
are thread safe - so would be better to just compile the regular expression once:

"All of the state involved in performing a match resides in the matcher, so many matchers
can share the same pattern."

> Move EmailValidator to routines package
> ---------------------------------------
>                 Key: VALIDATOR-242
>                 URL:
>             Project: Commons Validator
>          Issue Type: Task
>          Components: Framework, Routines
>    Affects Versions: 1.3.1 Release
>            Reporter: Ben Speakmon
>            Assignee: Ben Speakmon
>             Fix For: 1.4
> Move EmailValidator and associated tests to the routines package as part of its refactoring.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message