commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <>
Subject [jira] Commented: (VALIDATOR-247) Move CreditCardValidator to routines package and refactor
Date Wed, 14 Nov 2007 05:20:43 GMT


Niall Pemberton commented on VALIDATOR-247:

OK I've committed this. One difference from the patch was I retained the "Integer" options
for different credit card types and the CreditCardValidator(int) constructor. Which should
make migrating from the existing CreditCardValidator to the new "routines" package version
one easier.

> Move CreditCardValidator to routines package and refactor
> ---------------------------------------------------------
>                 Key: VALIDATOR-247
>                 URL:
>             Project: Commons Validator
>          Issue Type: Task
>          Components: Routines
>            Reporter: Ben Speakmon
>            Assignee: Niall Pemberton
>             Fix For: 1.4
>         Attachments:,
> Having copied CreditCardValidator to routines, it now needs to be refactored to use CodeValidator/LuhnCheckDigit/etc.
It might also make sense to break CreditCardType out into a separate 1.4-style typesafe enum
so it can be easily converted to a real enum for Validator 2.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message