commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] Commented: (CODEC-55) make all "business" method implementations of public API thread safe
Date Tue, 09 Oct 2007 18:08:50 GMT


Sebb commented on CODEC-55:

The RefinedSoundex class does not need a createThreadSafeABC() method.
Also the behaviour has been changed - previously a null parameter was accepted for the mapping.
This may be desirable, but it should be documented.

Findbugs points out:
* the field RefinedSoundex.US_ENGLISH_MAPPING needs to be private otherwise it can be changed
outside the class.
* the constructor parameter mapping is externally mutable. The data should be copied to private

There are similar problems with the Soundex class.

> make all "business" method implementations of public API thread safe 
> ---------------------------------------------------------------------
>                 Key: CODEC-55
>                 URL:
>             Project: Commons Codec
>          Issue Type: Wish
>            Reporter: Qingtian Wang
>         Attachments: concurrentCodecs.diff, concurrentQDiff.diff, urlcodec.patch
> Maybe most of the implementations are already thread safe. Just such that codec can say
so in general...

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message