commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FILEUPLOAD-148) FileItemFactory.setMaxStringLength()
Date Tue, 02 Oct 2007 09:48:50 GMT

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531731
] 

Jochen Wiedmann commented on FILEUPLOAD-148:
--------------------------------------------

Assuming UTF-32, which is the largest encoding I am aware of, you may set fileSizeMax to 4*
stringSizeMax and have an effective limit. Ok, that's not a hard limit, because the user might
use a more efficient encoding in terms of space, but that should be fine, IMO.


> FileItemFactory.setMaxStringLength()
> ------------------------------------
>
>                 Key: FILEUPLOAD-148
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-148
>             Project: Commons FileUpload
>          Issue Type: New Feature
>    Affects Versions: 1.2
>            Reporter: Stepan Koltsov
>
> Need method
> FileItemFactory.setMaxStringLength(int limitInBytes)
> When this parameter is set, calling of FileItem.getString() when getSize() exceeds limitInBytes
should throw Exception. This is required to avoid OOME in case of wrongly submitted forms
(i. e. when bad guy puts big file into the form field "fileDescription").
> Or even better sizeThreshold should be used for this value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message